multiline support for RSA key in env

.env_example

@@ -21,3 +21,6 @@ EMAIL_PASSWORD=CHANGE_ME
 # Wiki configuration
 WIKI_USER=NoteKfet2020
 WIKI_PASSWORD=
+
+# OIDC
+OIDC_RSA_PRIVATE_KEY=CHANGE_ME

README.md

@@ -61,8 +61,8 @@ Bien que cela permette de créer une instance sur toutes les distributions,
 6. (Optionnel) **Création d'une clé privée OpenID Connect**
 
 Pour activer le support d'OpenID Connect, il faut générer une clé privée, par
-exemple avec openssl (`openssl genrsa -out oidc.key 4096`), et renseigner son
+exemple avec openssl (`openssl genrsa -out oidc.key 4096`), et copier la clé dans .env dans le champ
-emplacement dans `OIDC_RSA_PRIVATE_KEY` (par défaut `/var/secrets/oidc.key`).
+`OIDC_RSA_PRIVATE_KEY`.
 
 7.  Enjoy :
 
@@ -237,8 +237,8 @@ Sinon vous pouvez suivre les étapes décrites ci-dessous.
 7. **Création d'une clé privée OpenID Connect**
 
 Pour activer le support d'OpenID Connect, il faut générer une clé privée, par
-exemple avec openssl (`openssl genrsa -out oidc.key 4096`), et renseigner son
+exemple avec openssl (`openssl genrsa -out oidc.key 4096`), et renseigner le champ
-emplacement dans `OIDC_RSA_PRIVATE_KEY` (par défaut `/var/secrets/oidc.key`).
+`OIDC_RSA_PRIVATE_KEY` dans le .env (par défaut `/var/secrets/oidc.key`).
 
 8.  *Enjoy \o/*
 

apps/food/api/serializers.py

@@ -3,7 +3,7 @@
 
 from rest_framework import serializers
 
-from ..models import Allergen, BasicFood, TransformedFood, QRCode
+from ..models import Allergen, Food, BasicFood, TransformedFood, QRCode
 
 
 class AllergenSerializer(serializers.ModelSerializer):
@@ -16,6 +16,16 @@ class AllergenSerializer(serializers.ModelSerializer):
         fields = '__all__'
 
 
+class FoodSerializer(serializers.ModelSerializer):
+    """
+    REST API Serializer for Food.
+    The djangorestframework plugin will analyse the model `Food` and parse all fields in the API.
+    """
+    class Meta:
+        model = Food
+        fields = '__all__'
+
+
 class BasicFoodSerializer(serializers.ModelSerializer):
     """
     REST API Serializer for BasicFood.

apps/food/api/urls.py

@@ -1,7 +1,7 @@
 # Copyright (C) 2018-2025 by BDE ENS Paris-Saclay
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-from .views import AllergenViewSet, BasicFoodViewSet, TransformedFoodViewSet, QRCodeViewSet
+from .views import AllergenViewSet, FoodViewSet, BasicFoodViewSet, TransformedFoodViewSet, QRCodeViewSet
 
 
 def register_food_urls(router, path):
@@ -9,6 +9,7 @@ def register_food_urls(router, path):
     Configure router for Food REST API.
     """
     router.register(path + '/allergen', AllergenViewSet)
+    router.register(path + '/food', FoodViewSet)
     router.register(path + '/basicfood', BasicFoodViewSet)
     router.register(path + '/transformedfood', TransformedFoodViewSet)
     router.register(path + '/qrcode', QRCodeViewSet)

apps/food/api/views.py

@@ -5,8 +5,8 @@ from api.viewsets import ReadProtectedModelViewSet
 from django_filters.rest_framework import DjangoFilterBackend
 from rest_framework.filters import SearchFilter
 
-from .serializers import AllergenSerializer, BasicFoodSerializer, TransformedFoodSerializer, QRCodeSerializer
+from .serializers import AllergenSerializer, FoodSerializer, BasicFoodSerializer, TransformedFoodSerializer, QRCodeSerializer
-from ..models import Allergen, BasicFood, TransformedFood, QRCode
+from ..models import Allergen, Food, BasicFood, TransformedFood, QRCode
 
 
 class AllergenViewSet(ReadProtectedModelViewSet):
@@ -22,6 +22,19 @@ class AllergenViewSet(ReadProtectedModelViewSet):
     search_fields = ['$name', ]
 
 
+class FoodViewSet(ReadProtectedModelViewSet):
+    """
+    REST API View set.
+    The djangorestframework plugin will get all `Food` objects, serialize it to JSON with the given serializer,
+    then render it on /api/food/food/
+    """
+    queryset = Food.objects.order_by('id')
+    serializer_class = FoodSerializer
+    filter_backends = [DjangoFilterBackend, SearchFilter]
+    filterset_fields = ['name', ]
+    search_fields = ['$name', ]
+
+
 class BasicFoodViewSet(ReadProtectedModelViewSet):
     """
     REST API View set.

apps/food/fixtures/initial.json

@@ -0,0 +1,100 @@
+[
+    {
+	"model": "food.allergen",
+	"pk": 1,
+	"fields": {
+	    "name": "Lait"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 2,
+	"fields": {
+	    "name": "Oeufs"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 3,
+	"fields": {
+	    "name": "Gluten"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 4,
+	"fields": {
+	    "name": "Fruits à coques"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 5,
+	"fields": {
+	    "name": "Arachides"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 6,
+	"fields": {
+	    "name": "Sésame"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 7,
+	"fields": {
+	    "name": "Soja"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 8,
+	"fields": {
+	    "name": "Céleri"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 9,
+	"fields": {
+	    "name": "Lupin"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 10,
+	"fields": {
+	    "name": "Moutarde"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 11,
+	"fields": {
+	    "name": "Sulfites"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 12,
+	"fields": {
+	    "name": "Crustacés"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 13,
+	"fields": {
+	    "name": "Mollusques"
+	}
+    },
+    {
+	"model": "food.allergen",
+	"pk": 14,
+	"fields": {
+	    "name": "Poissons"
+	}
+    }
+]

apps/food/forms.py

@@ -12,7 +12,7 @@ from note_kfet.inputs import Autocomplete
 from note_kfet.middlewares import get_current_request
 from permission.backends import PermissionBackend
 
-from .models import BasicFood, TransformedFood, QRCode
+from .models import Food, BasicFood, TransformedFood, QRCode
 
 
 class QRCodeForms(forms.ModelForm):
@@ -22,7 +22,6 @@ class QRCodeForms(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.fields['food_container'].queryset = self.fields['food_container'].queryset.filter(
-            is_ready=False,
             end_of_life__isnull=True,
             polymorphic_ctype__model='transformedfood',
         ).filter(PermissionBackend.filter_queryset(
@@ -151,3 +150,38 @@ class AddIngredientForms(forms.ModelForm):
     class Meta:
         model = TransformedFood
         fields = ('ingredients',)
+
+
+class ManageIngredientsForm(forms.Form):
+    """
+    Form to manage ingredient
+    """
+    fully_used = forms.BooleanField()
+    fully_used.initial = True
+    fully_used.required = True
+    fully_used.label = _('Fully used')
+
+    name = forms.CharField()
+    name.widget = Autocomplete(
+        model=Food,
+        resetable=True,
+        attrs={"api_url": "/api/food/food",
+               "class": "autocomplete"},
+    )
+    name.label = _('Name')
+
+    qrcode = forms.IntegerField()
+    qrcode.widget = Autocomplete(
+        model=QRCode,
+        resetable=True,
+        attrs={"api_url": "/api/food/qrcode/",
+               "name_field": "qr_code_number",
+               "class": "autocomplete"},
+    )
+    qrcode.label = _('QR code number')
+
+
+ManageIngredientsFormSet = forms.formset_factory(
+    ManageIngredientsForm,
+    extra=1,
+)

apps/food/templates/food/food_detail.html

@@ -39,6 +39,11 @@ SPDX-License-Identifier: GPL-3.0-or-later
 	<a class="btn btn-sm btn-primary" href="{% url "food:add_ingredient" pk=food.pk %}">
 	  {% trans "Add to a meal" %}
 	</a>
+      {% endif %}
+      {% if manage_ingredients %}
+        <a class="btn btn-sm btn-secondary" href="{% url "food:manage_ingredients" pk=food.pk %}">
+	  {% trans "Manage ingredients" %}
+	</a>
       {% endif %}
 	<a class="btn btn-sm btn-primary" href="{% url "food:food_list" %}">
 	  {% trans "Return to the food list" %}

apps/food/templates/food/manage_ingredients.html

@@ -0,0 +1,116 @@
+{% extends "base.html" %}
+{% comment %}
+Copyright (C) 2018-2025 by BDE ENS Paris-Saclay
+SPDX-License-Identifier: GPL-3.0-or-later
+{% endcomment %}
+{% load i18n crispy_forms_tags %}
+
+{% block content %}
+<div class="card bg-white mb-3">
+  <h3 class="card-header text-center">
+    {{ title }}
+  </h3>
+  <div class="card-body" id="form"></div>
+  <form method="post" action="">
+    {% csrf_token %}
+    <table class="table table-condensed table-striped">
+      {# Fill initial data #}
+      {% for display, form in formset %}
+      {% if forloop.first %}
+      <thead>
+	<tr>
+	  <th>{{ form.name.label }}</th>
+	  <th>{{ form.qrcode.label }}</th>
+	  <th>{{ form.fully_used.label }}</th>
+	</tr>
+      </thead>
+      <tbody id="form_body">
+	{% endif %}
+	{% if display %}
+	<tr class="row-formset ingredients">
+	{% else %}
+	<tr class="row-formset ingredients" style="display: none">
+	{% endif %}
+	  <td>{{ form.name }}</td>
+	  <td>{{ form.qrcode }}</td>
+	  <td>{{ form.fully_used }}</td>
+	</tr>
+      {% endfor %}
+      </tbody>
+    </table>
+
+    {# Display buttons to add and remove ingredients #}
+    <div class="card-body">
+      <div class="btn-group btn-block" role="group">
+	<button type="button" id="add_more" class="btn btn-success">{% trans "Add ingredient" %}</button>
+	<button type="button" id="remove_one" class="btn btn-danger">{% trans "Remove ingredient" %}</button>
+      </div>
+    <button class="btn btn-primary" type="submit">{% trans "Submit"%}</button>
+    </div>
+  </form>
+</div>
+
+{% endblock %}
+{% block extrajavascript %} 
+<script>
+/* script that handles add and remove lines */
+
+const foods = {{ ingredients | safe }};
+
+function set_ingredient_id () {
+	let ingredients = document.getElementsByClassName('ingredients');
+	for (var i = 0; i < ingredients.length; i++) {
+		ingredients[i].id = 'ingredients-' + parseInt(i);
+	};
+}
+set_ingredient_id();
+
+function prepopulate () {
+	for (var i = 0; i < {{ ingredients_count }}; i++) {
+		let prefix = 'id_form-' + parseInt(i) + '-';
+		document.getElementById(prefix + 'name_pk').value = parseInt(foods[i]['food_pk']);
+		document.getElementById(prefix + 'name').value = foods[i]['food_name'];
+		document.getElementById(prefix + 'qrcode_pk').value = parseInt(foods[i]['qr_pk']);
+		if (foods[i]['qr_number'] === '') {
+			document.getElementById(prefix + 'qrcode').value = '';
+		}
+		else {
+		document.getElementById(prefix + 'qrcode').value = parseInt(foods[i]['qr_number']);
+		};
+		document.getElementById(prefix + 'fully_used').checked = Boolean(foods[i]['fully_used']);
+	};
+}
+prepopulate();
+
+function delete_form_data (form_id) {
+	let prefix = "id_form-" + parseInt(form_id) + "-";
+	document.getElementById(prefix + "name_pk").value = "";
+	document.getElementById(prefix + "name").value = "";
+	document.getElementById(prefix + "qrcode_pk").value = "";
+	document.getElementById(prefix + "qrcode").value = "";
+	document.getElementById(prefix + "fully_used").checked = true;
+}
+var form_count = {{ ingredients_count }} + 1;
+
+$('#add_more').click(function () {
+	let ingredient_form = document.getElementById('ingredients-' + parseInt(form_count));
+	if (ingredient_form === null) {
+		addMsg(gettext("You can't add more ingredient"), "danger",  5000);
+		return;};
+	ingredient_form.style = "display: true";
+	form_count += 1;
+});
+  
+$('#remove_one').click(function () {
+	let ingredient_form = document.getElementById('ingredients-' + parseInt(form_count - 1));
+	if (ingredient_form === null) {
+		return;};
+	ingredient_form.style = "display: none";
+	delete_form_data(form_count - 1);
+	form_count -= 1;
+});
+
+addMsg(gettext("Add ingredient with their name or their qrcode, if two different priority is given to qrcode"), "warning"); 
+
+</script>
+{% endblock %}

apps/food/templates/food/transformedfood_update.html

@@ -0,0 +1,87 @@
+{% extends "base.html" %}
+{% comment %}
+Copyright (C) by BDE ENS Paris-Saclay
+SPDX-License-Identifier: GPL-3.0-or-later
+{% endcomment %}
+{% load i18n crispy_forms_tags %}
+
+{% block content %}
+<div class="card bg-white mb-3">
+  <h3 class="card-header text-center">
+    {{ title }}
+  </h3>
+  <div class="card-body" id="form">
+    <form method="post">
+      {% csrf_token %}
+      {{ form | crispy }}
+      <table class="table table-condensed table-striped">
+        {# Fill initial data #}
+        {% for ingredient_form in formset %}
+        {% if forloop.first %}
+        <thead>
+          <tr>
+	    <th>{% trans "Name" %}</th>
+	    <th>{% trans "QR-code number" %}</th>
+	    <th>{% trans "Fully used" %}<th>
+          </tr>
+        </thead>
+        <tbody id="form_body">
+        {% endif %}
+        <tr class="row-formset">
+		{{ ingredient_form | crispy }}
+          <td>{{ ingredient_form.name }}</td>
+	  <td>{{ ingredient_form.qrcode }}</td>
+	  <td>{{ ingredient_form.fully_used }}</td>
+        </tr>
+        {% endfor %}
+        </tbody>
+      </table>
+      {# Display buttons to add and remove products #}
+      <div class="card-body">
+        <div class="btn-group btn-block" role="group">
+          <button type="button" id="add_more" class="btn btn-success">{% trans "Add ingredient" %}</button>
+	  <button type="button" id="remove_one" class="btn btn-danger">{% trans "Remove ingredient" %}</button>
+        </div>
+        <button type="submit" class="btn btn-block btn-primary">{% trans "Submit" %}</button>
+      </div>
+    </form>
+  </div>
+</div>
+
+{# Hidden div that store an empty product form, to be copied into new forms #}
+<div id="empty_form" style="display: none;">
+    <table class='no_error'>
+        <tbody id="for_real">
+            <tr class="row-formset">
+                <td>{{ formset.empty_form.name }}</td>
+		<td>{{ formset.empty_form.qrcode }}</td>
+		<td>{{ formset.empty_form.fully_used }}</td>
+            </tr>
+        </tbody>
+    </table>
+</div>
+{% endblock %}
+{% block extrajavascript %}
+<script>
+    /* script that handles add and remove lines */
+    IDS = {};
+
+    $("#id_form-TOTAL_FORMS").val($(".row-formset").length - 1);
+
+    $('#add_more').click(function () {
+        let form_idx = $('#id_form-TOTAL_FORMS').val();
+        $('#form_body').append($('#for_real').html().replace(/__prefix__/g, form_idx));
+        $('#id_form-TOTAL_FORMS').val(parseInt(form_idx) + 1);
+        $('#id_form-' + parseInt(form_idx) + '-id').val(IDS[parseInt(form_idx)]);
+    });
+
+    $('#remove_one').click(function () {
+        let form_idx = $('#id_form-TOTAL_FORMS').val();
+        if (form_idx > 0) {
+            IDS[parseInt(form_idx) - 1] = $('#id_form-' + (parseInt(form_idx) - 1) + '-id').val();
+            $('#form_body tr:last-child').remove();
+            $('#id_form-TOTAL_FORMS').val(parseInt(form_idx) - 1);
+        }
+    });
+</script>
+{% endblock %}

apps/food/urls.py

@@ -13,6 +13,7 @@ urlpatterns = [
     path('<int:slug>/add/basic', views.BasicFoodCreateView.as_view(), name='basicfood_create'),
     path('add/transformed', views.TransformedFoodCreateView.as_view(), name='transformedfood_create'),
     path('update/<int:pk>', views.FoodUpdateView.as_view(), name='food_update'),
+    path('update/ingredients/<int:pk>', views.ManageIngredientsView.as_view(), name='manage_ingredients'),
     path('detail/<int:pk>', views.FoodDetailView.as_view(), name='food_view'),
     path('detail/basic/<int:pk>', views.BasicFoodDetailView.as_view(), name='basicfood_view'),
     path('detail/transformed/<int:pk>', views.TransformedFoodDetailView.as_view(), name='transformedfood_view'),

apps/food/views.py

@@ -7,8 +7,8 @@ from api.viewsets import is_regex
 from django_tables2.views import MultiTableMixin
 from django.db import transaction
 from django.db.models import Q
-from django.http import HttpResponseRedirect
+from django.http import HttpResponseRedirect, Http404
-from django.views.generic import DetailView, UpdateView
+from django.views.generic import DetailView, UpdateView, CreateView
 from django.views.generic.list import ListView
 from django.urls import reverse_lazy
 from django.utils import timezone
@@ -18,7 +18,9 @@ from permission.backends import PermissionBackend
 from permission.views import ProtectQuerysetMixin, ProtectedCreateView, LoginRequiredMixin
 
 from .models import Food, BasicFood, TransformedFood, QRCode
-from .forms import AddIngredientForms, BasicFoodForms, TransformedFoodForms, BasicFoodUpdateForms, TransformedFoodUpdateForms, QRCodeForms
+from .forms import QRCodeForms, BasicFoodForms, TransformedFoodForms, \
+    ManageIngredientsForm, ManageIngredientsFormSet, AddIngredientForms, \
+    BasicFoodUpdateForms, TransformedFoodUpdateForms
 from .tables import FoodTable
 from .utils import pretty_duration
 
@@ -61,7 +63,8 @@ class FoodListView(ProtectQuerysetMixin, LoginRequiredMixin, MultiTableMixin, Li
             valid_regex = is_regex(pattern)
             suffix = '__iregex' if valid_regex else '__istartswith'
             prefix = '^' if valid_regex else ''
-            qs = qs.filter(Q(**{f'name{suffix}': prefix + pattern}))
+            qs = qs.filter(Q(**{f'name{suffix}': prefix + pattern})
+                           | Q(**{f'owner__name{suffix}': prefix + pattern}))
         else:
             qs = qs.none()
         search_table = qs.filter(PermissionBackend.filter_queryset(self.request, Food, 'view'))
@@ -69,11 +72,17 @@ class FoodListView(ProtectQuerysetMixin, LoginRequiredMixin, MultiTableMixin, Li
         open_table = self.get_queryset().order_by('expiry_date').filter(
             Q(polymorphic_ctype__model='transformedfood')
             | Q(polymorphic_ctype__model='basicfood', basicfood__date_type='DLC')).filter(
-                expiry_date__lt=timezone.now()).filter(
+                expiry_date__lt=timezone.now(), end_of_life='').filter(
                     PermissionBackend.filter_queryset(self.request, Food, 'view'))
         # table served
         served_table = self.get_queryset().order_by('-pk').filter(
-            end_of_life='', is_ready=True)
+            end_of_life='', is_ready=True).exclude(
+                Q(polymorphic_ctype__model='basicfood',
+                  basicfood__date_type='DLC',
+                  expiry_date__lte=timezone.now(),)
+                | Q(polymorphic_ctype__model='transformedfood',
+                    expiry_date__lte=timezone.now(),
+                    ))
         # tables club
         bureau_role_pk = 4
         clubs = Club.objects.filter(membership__in=Membership.objects.filter(
@@ -100,7 +109,7 @@ class FoodListView(ProtectQuerysetMixin, LoginRequiredMixin, MultiTableMixin, Li
         return context
 
 
-class QRCodeCreateView(ProtectQuerysetMixin, ProtectedCreateView):
+class QRCodeCreateView(ProtectQuerysetMixin, LoginRequiredMixin, CreateView):
     """
     A view to add qrcode
     """
@@ -237,7 +246,72 @@ class TransformedFoodCreateView(ProtectQuerysetMixin, ProtectedCreateView):
         return reverse_lazy('food:transformedfood_view', kwargs={"pk": self.object.pk})
 
 
-class AddIngredientView(ProtectQuerysetMixin, UpdateView):
+MAX_FORMS = 10
+
+
+class ManageIngredientsView(ProtectQuerysetMixin, LoginRequiredMixin, UpdateView):
+    """
+    A view to manage ingredient for a transformed food
+    """
+    model = TransformedFood
+    fields = ['ingredients']
+    extra_context = {"title": _("Manage ingredients of:")}
+    template_name = 'food/manage_ingredients.html'
+
+    @transaction.atomic
+    def form_valid(self, form):
+        old_ingredients = list(self.object.ingredients.all()).copy()
+        old_allergens = list(self.object.allergens.all()).copy()
+        self.object.ingredients.clear()
+        for i in range(self.object.ingredients.all().count() + 1 + MAX_FORMS):
+            prefix = 'form-' + str(i) + '-'
+            if form.data[prefix + 'qrcode'] not in ['0', '']:
+                ingredient = QRCode.objects.get(pk=form.data[prefix + 'qrcode']).food_container
+                self.object.ingredients.add(ingredient)
+                if (prefix + 'fully_used') in form.data and form.data[prefix + 'fully_used'] == 'on':
+                    ingredient.end_of_life = _('Fully used in {meal}'.format(
+                        meal=self.object.name))
+                    ingredient.save()
+
+            elif form.data[prefix + 'name'] != '':
+                ingredient = Food.objects.get(pk=form.data[prefix + 'name'])
+                self.object.ingredients.add(ingredient)
+                if (prefix + 'fully_used') in form.data and form.data[prefix + 'fully_used'] == 'on':
+                    ingredient.end_of_life = _('Fully used in {meal}'.format(
+                        meal=self.object.name))
+                    ingredient.save()
+
+        self.object.save(old_ingredients=old_ingredients, old_allergens=old_allergens)
+        return HttpResponseRedirect(self.get_success_url())
+
+    def get_context_data(self, *args, **kwargs):
+        context = super().get_context_data(*args, **kwargs)
+        context['title'] += ' ' + self.object.name
+        formset = ManageIngredientsFormSet()
+        ingredients = self.object.ingredients.all()
+        formset.extra += ingredients.count() + MAX_FORMS
+        context['form'] = ManageIngredientsForm()
+        context['ingredients_count'] = ingredients.count()
+        display = [True] * (1 + ingredients.count()) + [False] * (formset.extra - ingredients.count() - 1)
+        context['formset'] = zip(display, formset)
+        context['ingredients'] = []
+        for ingredient in ingredients:
+            qr = QRCode.objects.filter(food_container=ingredient)
+
+            context['ingredients'].append({
+                'food_pk': ingredient.pk,
+                'food_name': ingredient.name,
+                'qr_pk': '' if qr.count() == 0 else qr[0].pk,
+                'qr_number': '' if qr.count() == 0 else qr[0].qr_code_number,
+                'fully_used': 'true' if ingredient.end_of_life else '',
+            })
+        return context
+
+    def get_success_url(self, **kwargs):
+        return reverse_lazy('food:transformedfood_view', kwargs={"pk": self.object.pk})
+
+
+class AddIngredientView(ProtectQuerysetMixin, LoginRequiredMixin, UpdateView):
     """
     A view to add ingredient to a meal
     """
@@ -254,6 +328,8 @@ class AddIngredientView(ProtectQuerysetMixin, UpdateView):
     @transaction.atomic
     def form_valid(self, form):
         meals = TransformedFood.objects.filter(pk__in=form.data.getlist('ingredients')).all()
+        if not meals:
+            return HttpResponseRedirect(reverse_lazy('food:food_view', kwargs={"pk": self.object.pk}))
         for meal in meals:
             old_ingredients = list(meal.ingredients.all()).copy()
             old_allergens = list(meal.allergens.all()).copy()
@@ -354,10 +430,12 @@ class FoodDetailView(ProtectQuerysetMixin, LoginRequiredMixin, DetailView):
             value) for field, value in fields.items()]
         context["meals"] = self.object.transformed_ingredient_inv.all()
         context["update"] = PermissionBackend.check_perm(self.request, "food.change_food")
-        context["add_ingredient"] = self.object.end_of_life = '' and PermissionBackend.check_perm(self.request, "food.change_transformedfood")
+        context["add_ingredient"] = (self.object.end_of_life == '' and PermissionBackend.check_perm(self.request, "food.change_transformedfood"))
         return context
 
     def get(self, *args, **kwargs):
+        if Food.objects.filter(pk=kwargs['pk']).count() != 1:
+            return Http404
         model = Food.objects.get(pk=kwargs['pk']).polymorphic_ctype.model
         if 'stop_redirect' in kwargs and kwargs['stop_redirect']:
             return super().get(*args, **kwargs)
@@ -379,7 +457,8 @@ class BasicFoodDetailView(FoodDetailView):
         return context
 
     def get(self, *args, **kwargs):
-        kwargs['stop_redirect'] = (Food.objects.get(pk=kwargs['pk']).polymorphic_ctype.model == 'basicfood')
+        if Food.objects.filter(pk=kwargs['pk']).count() == 1:
+            kwargs['stop_redirect'] = (Food.objects.get(pk=kwargs['pk']).polymorphic_ctype.model == 'basicfood')
         return super().get(*args, **kwargs)
 
 
@@ -395,8 +474,10 @@ class TransformedFoodDetailView(FoodDetailView):
             pretty_duration(self.object.shelf_life)
         ))
         context["foods"] = self.object.ingredients.all()
+        context["manage_ingredients"] = True
         return context
 
     def get(self, *args, **kwargs):
-        kwargs['stop_redirect'] = (Food.objects.get(pk=kwargs['pk']).polymorphic_ctype.model == 'transformedfood')
+        if Food.objects.filter(pk=kwargs['pk']).count() == 1:
+            kwargs['stop_redirect'] = (Food.objects.get(pk=kwargs['pk']).polymorphic_ctype.model == 'transformedfood')
         return super().get(*args, **kwargs)

apps/permission/fixtures/initial.json

@@ -3307,436 +3307,184 @@
         }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 211,
+	"pk": 211,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "transformedfood"
+		"qrcode"
-            ],
+	    ],
-            "query": "{}",
+	    "query": "{}",
-            "type": "view",
+	    "type": "view",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir n'importe quel QR-code"
-            "description": "Voir tout les plats"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 212,
+	"pk": 212,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "transformedfood"
+		"allergen"
-            ],
+	    ],
-            "query": "{\"owner\": [\"club\"]}",
+	    "query": "{}",
-            "type": "view",
+	    "type": "view",
-            "mask": 3,
+	    "mask": 1,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir n'importe quel allergène"
-            "description": "Voir tout les plats de son club"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 213,
+	"pk": 213,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "transformedfood"
+		"food"
-            ],
+	    ],
-            "query": "{\"is_ready\": true}",
+	    "query": "{}",
-            "type": "view",
+	    "type": "view",
-            "mask": 1,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir n'importe quelle bouffe"
-            "description": "Voir les plats préparés actifs servis"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 214,
+	"pk": 214,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "qrcode"
+		"qrcode"
-            ],
+	    ],
-            "query": "{}",
+	    "query": "{}",
-            "type": "add",
+	    "type": "add",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Ajouter n'importe quel QR-code"
-            "description": "Initialiser un QR code de traçabilité"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 215,
+	"pk": 215,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"food"
-            ],
+	    ],
-            "query": "{\"owner\": [\"club\"]}",
+	    "query": "{}",
-            "type": "add",
+	    "type": "add",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Ajouter n'importe quelle bouffe"
-            "description": "Créer un nouvel ingrédient pour son club"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 216,
+	"pk": 216,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"food"
-            ],
+	    ],
-            "query": "{}",
+	    "query": "{}",
-            "type": "add",
+	    "type": "change",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Modifier n'importe quelle bouffe"
-            "description": "Créer un nouvel ingrédient"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 217,
+	"pk": 217,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"qrcode"
-            ],
+	    ],
-            "query": "{}",
+	    "query": "{\"food_container__owner\": [\"club\"]}",
-            "type": "view",
+	    "type": "view",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir un QR-code lié à son club"
-            "description": "Voir toute la bouffe"
+    	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 218,
+	"pk": 218,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"food"
-            ],
+	    ],
-            "query": "{\"is_ready\": true}",
+	    "query": "{\"owner\": [\"club\"]}",
-            "type": "view",
+	    "type": "view",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir la bouffe de son club"
-            "description": "Voir toute la bouffe active"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 219,
+	"pk": 219,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"qrcode"
-            ],
+	    ],
-            "query": "{\"is_ready\": true, \"owner\": [\"club\"]}",
+	    "query": "{\"food_container__owner\": [\"club\"]}",
-            "type": "view",
+	    "type": "add",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Ajouter un QR-code pour son club"
-            "description": "Voir la bouffe active de son club"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 220,
+	"pk": 220,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"food"
-            ],
+	    ],
-            "query": "{}",
+	    "query": "{\"owner\": [\"club\"]}",
-            "type": "change",
+	    "type": "add",
-            "mask": 3,
+	    "mask": 2,
-            "field": "",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Ajouter de la bouffe appartenant à son club"
-            "description": "Modifier de la bouffe"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 221,
+	"pk": 221,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+		"food",
-                "basicfood"
+		"food"
-            ],
+	    ],
-            "query": "{\"is_ready\": true}",
+	    "query": "{\"owner\": [\"club\"]}",
-            "type": "change",
+	    "type": "change",
-            "mask": 3,
+	    "mask": 2,
-            "field": "allergens",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Modifier la bouffe appartenant à son club"
-            "description": "Modifier les allergènes de la bouffe existante"
+	}
-        }
     },
     {
-        "model": "permission.permission",
+	"model": "permission.permission",
-        "pk": 222,
+	"pk": 222,
-        "fields": {
+	"fields": {
-            "model": [
+	    "model": [
-                "food",
+	        "food",
-                "basicfood"
+    		"food"
-            ],
+	    ],
-            "query": "{\"is_ready\": true, \"owner\": [\"club\"]}",
+	    "query": "{\"end_of_life\": \"\"}",
-            "type": "change",
+	    "type": "view",
-            "mask": 3,
+	    "mask": 1,
-            "field": "allergens",
+	    "permanent": false,
-            "permanent": false,
+	    "description": "Voir la bouffe servie"
-            "description": "Modifier les allergènes de la bouffe appartenant à son club"
+	}
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 223,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{}",
-            "type": "add",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Créer un plat"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 224,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{\"owner\": [\"club\"]}",
-            "type": "add",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Créer un plat pour son club"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 225,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{}",
-            "type": "change",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Modifier tout les plats"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 226,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{\"is_ready\": true}",
-            "type": "change",
-            "mask": 3,
-            "field": "end_of_life",
-            "permanent": false,
-            "description": "Indiquer si un plat a été mangé"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 227,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{\"is_ready\": true, \"owner\": [\"club\"]}",
-            "type": "change",
-            "mask": 3,
-            "field": "is_ready",
-            "permanent": false,
-            "description": "Indiquer si un plat de son club est prêt"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 228,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{\"is_ready\": true}",
-            "type": "change",
-            "mask": 3,
-            "field": "is_ready",
-            "permanent": false,
-            "description": "Archiver un plat"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 229,
-        "fields": {
-            "model": [
-                "food",
-                "basicfood"
-            ],
-            "query": "{\"is_ready\": true}",
-            "type": "change",
-            "mask": 3,
-            "field": "is_ready",
-            "permanent": false,
-            "description": "Archiver de la bouffe"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 231,
-        "fields": {
-            "model": [
-                "food",
-                "qrcode"
-            ],
-            "query": "{}",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir tous les QR codes"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 232,
-        "fields": {
-            "model": [
-                "food",
-                "qrcode"
-            ],
-            "query": "{\"food_container__is_ready\": true}",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir tous les QR codes actifs"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 233,
-        "fields": {
-            "model": [
-                "food",
-                "qrcode"
-            ],
-            "query": "{\"food_container__owner\": [\"club\"], \"food_container__is_ready\": true}",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir tous les QR codes actifs de son club"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk" : 234,
-        "fields": {
-            "model": [
-                "food",
-                "transformedfood"
-            ],
-            "query": "{\"owner\": [\"club\"]}",
-            "type": "change",
-            "mask": 3,
-            "field": "ingredients",
-            "permanent": false,
-            "description": "Changer les ingrédients d'un plat actif de son club"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 235,
-        "fields": {
-            "model": [
-                "food",
-                "food"
-            ],
-            "query": "{}",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir bouffe"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 236,
-        "fields": {
-            "model": [
-                "food",
-                "food"
-            ],
-            "query": "[]",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir bouffe active"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 237,
-        "fields": {
-            "model": [
-                "food",
-                "food"
-            ],
-            "query": "{\"owner\": [\"club\"]}",
-            "type": "view",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Voir bouffe active de son club"
-        }
-    },
-    {
-        "model": "permission.permission",
-        "pk": 238,
-        "fields": {
-            "model": [
-                "food",
-                "food"
-            ],
-            "query": "{}",
-            "type": "change",
-            "mask": 3,
-            "field": "",
-            "permanent": false,
-            "description": "Modifier bouffe"
-        }
     },
     {
         "model": "permission.permission",
@@ -4343,7 +4091,8 @@
                 158,
                 159,
                 160,
-                213
+		212,
+		222
             ]
         }
     },
@@ -4384,16 +4133,11 @@
                 50,
                 141,
                 169,
-                212,
+		217,
-                214,
+		218,
-                215,
+		219,
-                219,
+		220,
-                222,
+		221,
-                224,
-                227,
-                233,
-                234,
-                237,
 		247,
 		258,
 		259
@@ -4574,20 +4318,7 @@
                 166,
                 167,
                 168,
-                182,
+                182
-                212,
-                214,
-                215,
-                218,
-                221,
-                224,
-                226,
-                227,
-                228,
-                229,
-                232,
-                234,
-                236
             ]
         }
     },
@@ -4795,8 +4526,7 @@
                 168,
                 176,
                 177,
-                197,
+                197
-                211
             ]
         }
     },
@@ -4824,15 +4554,11 @@
             "permissions": [
                 137,
                 211,
-                214,
+                212,
-                216,
+		213,
-                217,
+		214,
-                220,
+		215,
-                223,
+		216
-                225,
-                231,
-                235,
-                238
             ]
         }
     },  

apps/permission/scopes.py

@@ -1,8 +1,10 @@
 # Copyright (C) 2018-2025 by BDE ENS Paris-Saclay
 # SPDX-License-Identifier: GPL-3.0-or-later
+
 from oauth2_provider.oauth2_validators import OAuth2Validator
 from oauth2_provider.scopes import BaseScopes
 from member.models import Club
+from note.models import Alias
 from note_kfet.middlewares import get_current_request
 
 from .backends import PermissionBackend
@@ -17,25 +19,46 @@ class PermissionScopes(BaseScopes):
     """
 
     def get_all_scopes(self):
-        return {f"{p.id}_{club.id}": f"{p.description} (club {club.name})"
+        scopes = {f"{p.id}_{club.id}": f"{p.description} (club {club.name})"
-                for p in Permission.objects.all() for club in Club.objects.all()}
+                  for p in Permission.objects.all() for club in Club.objects.all()}
+        scopes['openid'] = "OpenID Connect"
+        return scopes
 
     def get_available_scopes(self, application=None, request=None, *args, **kwargs):
         if not application:
             return []
-        return [f"{p.id}_{p.membership.club.id}"
+        scopes = [f"{p.id}_{p.membership.club.id}"
-                for t in Permission.PERMISSION_TYPES
+                  for t in Permission.PERMISSION_TYPES
-                for p in PermissionBackend.get_raw_permissions(get_current_request(), t[0])]
+                  for p in PermissionBackend.get_raw_permissions(get_current_request(), t[0])]
+        scopes.append('openid')
+        return scopes
 
     def get_default_scopes(self, application=None, request=None, *args, **kwargs):
         if not application:
             return []
-        return [f"{p.id}_{p.membership.club.id}"
+        scopes = [f"{p.id}_{p.membership.club.id}"
-                for p in PermissionBackend.get_raw_permissions(get_current_request(), 'view')]
+                  for p in PermissionBackend.get_raw_permissions(get_current_request(), 'view')]
+        scopes.append('openid')
+        return scopes
 
 
 class PermissionOAuth2Validator(OAuth2Validator):
-    oidc_claim_scope = None  # fix breaking change of django-oauth-toolkit 2.0.0
+    oidc_claim_scope = OAuth2Validator.oidc_claim_scope
+    oidc_claim_scope.update({"name": 'openid',
+                             "normalized_name": 'openid',
+                             "email": 'openid',
+                             })
+
+    def get_additional_claims(self, request):
+        return {
+            "name": request.user.username,
+            "normalized_name": Alias.normalize(request.user.username),
+            "email": request.user.email,
+        }
+
+    def get_discovery_claims(self, request):
+        claims = super().get_discovery_claims(self)
+        return claims + ["name", "normalized_name", "email"]
 
     def validate_scopes(self, client_id, scopes, client, request, *args, **kwargs):
         """
@@ -54,6 +77,8 @@ class PermissionOAuth2Validator(OAuth2Validator):
                 if scope in scopes:
                     valid_scopes.add(scope)
 
-        request.scopes = valid_scopes
+        if 'openid' in scopes:
+            valid_scopes.add('openid')
 
+        request.scopes = valid_scopes
         return valid_scopes

apps/permission/signals.py

@@ -19,6 +19,7 @@ EXCLUDED = [
     'oauth2_provider.accesstoken',
     'oauth2_provider.grant',
     'oauth2_provider.refreshtoken',
+    'oauth2_provider.idtoken',
     'sessions.session',
 ]
 

apps/permission/views.py

@@ -171,7 +171,7 @@ class ScopesView(LoginRequiredMixin, TemplateView):
             available_scopes = scopes.get_available_scopes(app)
             context["scopes"][app] = OrderedDict()
             items = [(k, v) for (k, v) in all_scopes.items() if k in available_scopes]
-            items.sort(key=lambda x: (int(x[0].split("_")[1]), int(x[0].split("_")[0])))
+            # items.sort(key=lambda x: (int(x[0].split("_")[1]), int(x[0].split("_")[0])))
             for k, v in items:
                 context["scopes"][app][k] = v
 

docs/apps/food.rst

@@ -19,8 +19,9 @@ Le modèle regroupe :
 * Propriétaire (doit-être un Club)
 * Allergènes (ManyToManyField)
 * date d'expiration
-* a été mangé (booléen)
+* fin de vie
 * est prêt (booléen)
+* consigne (pour les GCKs)
 
 BasicFood
 ~~~~~~~~~
@@ -40,7 +41,7 @@ Les TransformedFood correspondent aux produits préparés à la Kfet. Ils peuven
 
 Le modèle regroupe :
 
-* Durée de consommation (par défaut 3 jours)
+* Durée de conservation (par défaut 3 jours)
 * Ingrédients (ManyToManyField vers Food)
 * Date de création
 * Champs de Food

docs/apps/index.rst

@@ -12,6 +12,7 @@ Applications de la Note Kfet 2020
    ../api/index
    registration
    logs
+   food
    treasury
    wei
    wrapped
@@ -66,6 +67,8 @@ Applications facultatives
     Serveur central d'authentification, permet d'utiliser son compte de la NoteKfet2020 pour se connecter à d'autre application ayant intégrer un client.
 * `Scripts <https://gitlab.crans.org/bde/nk20-scripts>`_
      Ensemble de commande `./manage.py` pour la gestion de la note: import de données, verification d'intégrité, etc...
+* `Food <food>`_ :
+    Gestion de la nourriture dans Kfet pour les clubs.
 * `Treasury <treasury>`_ :
     Interface de gestion pour les trésorièr⋅es, émission de factures, remises de chèque, statistiques...
 * `WEI <wei>`_ :

docs/faq.rst

@@ -183,6 +183,7 @@ Contributeur⋅rices
    * korenst1
    * nicomarg
    * PAC
+   * Quark
    * ÿnérant
 
 

note_kfet/settings/base.py

@@ -270,7 +270,7 @@ OAUTH2_PROVIDER = {
     'PKCE_REQUIRED': False, # PKCE (fix a breaking change of django-oauth-toolkit 2.0.0)
     'OIDC_ENABLED': True,
     'OIDC_RSA_PRIVATE_KEY':
-        os.getenv('OIDC_RSA_PRIVATE_KEY', '/var/secrets/oidc.key'),
+        os.getenv('OIDC_RSA_PRIVATE_KEY', 'CHANGE_ME_IN_ENV_SETTINGS').replace('\\n', '\n'), # for multilines
     'SCOPES': { 'openid': "OpenID Connect scope" },
 }